From eef2c9954cdc865c3cf51fb28de52293b7c7337d Mon Sep 17 00:00:00 2001 From: javiermengual Date: Thu, 5 Feb 2026 14:38:47 +0100 Subject: [PATCH] quito anotaciones de los Controllers para mayor legibilidad. --- .../Controllers/ClientsController.cs | 3 -- .../Controllers/InvoicesController.cs | 40 ------------------- 2 files changed, 43 deletions(-) diff --git a/DoliMiddlewareApi/Controllers/ClientsController.cs b/DoliMiddlewareApi/Controllers/ClientsController.cs index 4f276a7..f35a9d3 100644 --- a/DoliMiddlewareApi/Controllers/ClientsController.cs +++ b/DoliMiddlewareApi/Controllers/ClientsController.cs @@ -13,9 +13,6 @@ public class ClientsController(ClientService clientService) : ControllerBase { [HttpGet] - [ProducesResponseType(typeof(List), StatusCodes.Status200OK)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status400BadRequest)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status500InternalServerError)] public async Task>> GetClientes( [FromQuery] int limit = 50, [FromQuery][Range(1, int.MaxValue)] int page = 1) diff --git a/DoliMiddlewareApi/Controllers/InvoicesController.cs b/DoliMiddlewareApi/Controllers/InvoicesController.cs index 541947f..6b00b40 100644 --- a/DoliMiddlewareApi/Controllers/InvoicesController.cs +++ b/DoliMiddlewareApi/Controllers/InvoicesController.cs @@ -13,9 +13,6 @@ namespace DoliMiddlewareApi.Controllers; public class InvoicesController(InvoiceService invoiceService) : ControllerBase { [HttpGet] - [ProducesResponseType(typeof(List), StatusCodes.Status200OK)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status400BadRequest)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status500InternalServerError)] public async Task>> GetInvoices( [FromQuery] int limit = 50, [FromQuery][Range(1, int.MaxValue)] int page = 1, @@ -27,10 +24,6 @@ public class InvoicesController(InvoiceService invoiceService) : ControllerBase } [HttpGet("{id:int}")] - [ProducesResponseType(typeof(InvoiceDetailDto), StatusCodes.Status200OK)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status400BadRequest)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status404NotFound)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status500InternalServerError)] public async Task> GetInvoice([Range(1, int.MaxValue)] int id) { var invoice = await invoiceService.GetInvoiceAsync(id); @@ -38,9 +31,6 @@ public class InvoicesController(InvoiceService invoiceService) : ControllerBase } [HttpPost] - [ProducesResponseType(typeof(int), StatusCodes.Status201Created)] // Devuelve el ID creado - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status400BadRequest)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status500InternalServerError)] public async Task> CreateInvoice([FromBody] CreateInvoiceDto createInvoiceDto) { var invoiceId = await invoiceService.CreateInvoiceAsync(createInvoiceDto); @@ -48,11 +38,6 @@ public class InvoicesController(InvoiceService invoiceService) : ControllerBase } [HttpPut("{id:int}")] - [ProducesResponseType(StatusCodes.Status204NoContent)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status400BadRequest)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status403Forbidden)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status404NotFound)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status500InternalServerError)] public async Task UpdateInvoice([Range(1, int.MaxValue)] int id, [FromBody] UpdateInvoiceDto updateInvoiceDto) { await invoiceService.UpdateInvoiceAsync(id, updateInvoiceDto); @@ -60,11 +45,6 @@ public class InvoicesController(InvoiceService invoiceService) : ControllerBase } [HttpPost("{id:int}/lines")] - [ProducesResponseType(typeof(string), StatusCodes.Status201Created)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status400BadRequest)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status403Forbidden)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status404NotFound)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status500InternalServerError)] public async Task> AddInvoiceLine([Range(1, int.MaxValue)] int id, [FromBody] CreateInvoiceLineDto lineDto) { var result = await invoiceService.AddInvoiceLineAsync(id, lineDto); @@ -72,11 +52,6 @@ public class InvoicesController(InvoiceService invoiceService) : ControllerBase } [HttpPatch("{id:int}/status")] - [ProducesResponseType(StatusCodes.Status204NoContent)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status400BadRequest)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status403Forbidden)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status404NotFound)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status500InternalServerError)] public async Task UpdateInvoiceStatus( [Range(1, int.MaxValue)] int id, [FromBody] UpdateInvoiceStatusDto updateStatusDto) @@ -86,11 +61,6 @@ public class InvoicesController(InvoiceService invoiceService) : ControllerBase } [HttpPost("{id:int}/validate")] - [ProducesResponseType(StatusCodes.Status204NoContent)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status400BadRequest)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status403Forbidden)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status404NotFound)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status500InternalServerError)] public async Task ValidateInvoice([Range(1, int.MaxValue)] int id) { await invoiceService.ValidateInvoiceAsync(id); @@ -98,11 +68,6 @@ public class InvoicesController(InvoiceService invoiceService) : ControllerBase } [HttpDelete("{id:int}")] - [ProducesResponseType(StatusCodes.Status204NoContent)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status400BadRequest)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status403Forbidden)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status404NotFound)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status500InternalServerError)] public async Task DeleteInvoice([Range(1, int.MaxValue)] int id) { await invoiceService.DeleteInvoiceAsync(id); @@ -110,11 +75,6 @@ public class InvoicesController(InvoiceService invoiceService) : ControllerBase } [HttpDelete("{invoiceId:int}/lines/{lineId:int}")] - [ProducesResponseType(StatusCodes.Status204NoContent)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status400BadRequest)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status403Forbidden)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status404NotFound)] - [ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status500InternalServerError)] public async Task DeleteInvoiceLine( [Range(1, int.MaxValue)] int invoiceId, [Range(1, int.MaxValue)] int lineId)