mireya.2526
/
ProyectoIntermodular
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: handle PS 8.x {"products":false} response in getProductByReference 

PS 8.2.5 returns {"products": false} instead of {"products": []}
when a reference filter finds no matching products. Jackson cannot
deserialize false as a List, throwing HttpMessageConversionException.
Catch it and return Optional.empty() so pushProduct takes the CREATE
path correctly.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
luklpz 2026-05-17 18:12:21 +02:00
parent 9fd11219af
commit ca7948d6e6
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sync-service/src/main/java/com/teterialosjuanjos/tfg/sync_service/integration/prestashop/PrestashopClient.java
View File

@ -6,6 +6,7 @@ import com.teterialosjuanjos.tfg.sync_service.integration.prestashop.exception.P
import lombok.extern.slf4j.Slf4j; import lombok.extern.slf4j.Slf4j;
import org.springframework.beans.factory.annotation.Qualifier; import org.springframework.beans.factory.annotation.Qualifier;
import org.springframework.http.MediaType; import org.springframework.http.MediaType;
import org.springframework.http.converter.HttpMessageConversionException;
import org.springframework.stereotype.Component; import org.springframework.stereotype.Component;
import org.springframework.web.client.RestClient; import org.springframework.web.client.RestClient;
@ -87,6 +88,10 @@ public class PrestashopClient {
// PS may return 404 instead of 200+empty when filter finds no results // PS may return 404 instead of 200+empty when filter finds no results
if (e.getStatusCode() != null && e.getStatusCode().value() == 404) return Optional.empty(); if (e.getStatusCode() != null && e.getStatusCode().value() == 404) return Optional.empty();
throw e; throw e;
} catch (HttpMessageConversionException e) {
// PS 8.x returns {"products": false} instead of {"products": []} when filter has no results
log.debug("PS returned unparseable body for reference filter={}, treating as not found", reference);
return Optional.empty();
} }
} }