fix: handle Dolibarr/PS 404 on empty filter results

Both APIs return 404 (not 200+empty) when a filter finds no results.
Catch DolibarrApiException(404) in getOrCreateThirdparty and
getProductByRef; catch PrestashopApiException(404) in
getProductByReference — treat as empty/not-found instead of error.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

sync-service/src/main/java/com/teterialosjuanjos/tfg/sync_service/integration/dolibarr/DolibarrClient.java

@@ -1,6 +1,7 @@
 package com.teterialosjuanjos.tfg.sync_service.integration.dolibarr;
 
 import com.teterialosjuanjos.tfg.sync_service.integration.dolibarr.dto.*;
+import com.teterialosjuanjos.tfg.sync_service.integration.dolibarr.exception.DolibarrApiException;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.beans.factory.annotation.Qualifier;
 import org.springframework.core.ParameterizedTypeReference;
@@ -50,6 +51,7 @@ public class DolibarrClient {
      */
     public DolibarrProductDto getProductByRef(String ref) {
         String filter = "(t.ref:=:'%s')".formatted(ref);
+        try {
             List<DolibarrProductDto> results = restClient.get()
                     .uri(u -> u.path("/products")
                             .queryParam("sqlfilters", filter)
@@ -57,8 +59,11 @@ public class DolibarrClient {
                             .build())
                     .retrieve()
                     .body(new ParameterizedTypeReference<List<DolibarrProductDto>>() {});
-
             return (results != null && !results.isEmpty()) ? results.get(0) : null;
+        } catch (DolibarrApiException e) {
+            if (e.getStatusCode().value() == 404) return null;
+            throw e;
+        }
     }
 
     /**
@@ -119,13 +124,21 @@ public class DolibarrClient {
      */
     public DolibarrThirdpartyDto getOrCreateThirdparty(String email, String name) {
         log.debug("Looking up Dolibarr thirdparty email={}", email);
-        List<DolibarrThirdpartyDto> matches = restClient.get()
+        List<DolibarrThirdpartyDto> matches = null;
+        try {
+            matches = restClient.get()
                     .uri(u -> u.path("/thirdparties")
                             .queryParam("sqlfilters", "(t.email:=:'%s')".formatted(email))
                             .queryParam("limit", 1)
                             .build())
                     .retrieve()
                     .body(new ParameterizedTypeReference<List<DolibarrThirdpartyDto>>() {});
+        } catch (DolibarrApiException e) {
+            // Dolibarr returns 404 (not 200 + empty array) when filter finds no results
+            if (e.getStatusCode().value() != 404) {
+                throw e;
+            }
+        }
 
         if (matches != null && !matches.isEmpty()) {
             return matches.get(0);

sync-service/src/main/java/com/teterialosjuanjos/tfg/sync_service/integration/prestashop/PrestashopClient.java

@@ -2,6 +2,7 @@ package com.teterialosjuanjos.tfg.sync_service.integration.prestashop;
 
 import com.teterialosjuanjos.tfg.sync_service.config.IntegrationProperties;
 import com.teterialosjuanjos.tfg.sync_service.integration.prestashop.dto.*;
+import com.teterialosjuanjos.tfg.sync_service.integration.prestashop.exception.PrestashopApiException;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.beans.factory.annotation.Qualifier;
 import org.springframework.http.MediaType;
@@ -66,6 +67,7 @@ public class PrestashopClient {
     public Optional<PrestashopProductDto> getProductByReference(String reference) {
         // PS WebService requires [value] brackets for exact-match filtering
         String exactRef = "[" + reference + "]";
+        try {
             PrestashopProductDto.ListResponse response = restClient.get()
                     .uri(u -> u.path("/products")
                             .queryParam("ws_key", wsKey)
@@ -80,6 +82,11 @@ public class PrestashopClient {
                 return Optional.empty();
             }
             return Optional.of(response.products().get(0));
+        } catch (PrestashopApiException e) {
+            // PS may return 404 instead of 200+empty when filter finds no results
+            if (e.getStatusCode() != null && e.getStatusCode().value() == 404) return Optional.empty();
+            throw e;
+        }
     }
 
     /**